impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build
Date Tue, 18 Oct 2016 00:24:31 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-2916: Add warning to query profile if debug build
......................................................................


Patch Set 1:

(2 comments)

Thanks for the review, please see PS2.

http://gerrit.cloudera.org:8080/#/c/4588/1/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:

PS1, Line 88: WARNING
> Let's not use such a generic key. How about "Debug Mode Warning" ?
Done. I made the key all uppercase, so it becomes very easy to spot. Let me know if you think
it's too much.


PS1, Line 88: "WARNING", "This profile has been created by a DEBUG build. If "
            :       "you are looking for performance related information, we suggest to use
a RELEASE "
            :       "build instead."
> Just a suggestion to make it snappier:
Thanks, done.


-- 
To view, visit http://gerrit.cloudera.org:8080/4588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85ce4d4a5624382203e6b2c8f5b96d04c4482f37
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message