impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations
Date Mon, 17 Oct 2016 22:39:09 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4720/2/bin/impala-config.sh
File bin/impala-config.sh:

PS2, Line 333: exanded
> "expanded"
Done


PS2, Line 335: ${HADOOP_HOME}/share/hadoop/tools/lib/*
> Just checking, but does this need updating too?
I don't think right now - we don't need this to build Impala.


PS2, Line 404: ${HADOOP_HOME}/lib/native/
> There are more here.
Done


PS2, Line 424: ${HADOOP_HOME}/lib/native
> And here.
Done. I suspect this line isn't necessary but we can leave that to a separate change.


-- 
To view, visit http://gerrit.cloudera.org:8080/4720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7da10e38f9c4309f2d193dc25f14a6ea308c9639
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Charlie Helin <chelin@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message