impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.
Date Mon, 17 Oct 2016 22:04:59 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2789: More compact mem layout with null bits at the end.
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4673/7/be/src/runtime/descriptors.cc
File be/src/runtime/descriptors.cc:

PS7, Line 575: // (in this case the tuple contains only a nullable double)
             : // define void @SetNotNull({ i8, double }* %tuple) {
             : // entry:
             : //   %null_byte_ptr = getelementptr inbounds { i8, double }* %tuple, i32 0,
i32 0
             : //   %null_byte = load i8* %null_byte_ptr
             : //   %0 = and i8 %null_byte, -2
             : //   store i8 %0, i8* %null_byte_ptr
             : //   ret void
> this looks outdated.
Thanks, I'll post a follow-on to update this.


-- 
To view, visit http://gerrit.cloudera.org:8080/4673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6510c75d841bddafa6638f1bd2ac6731a7053f6
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message