impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Remove Llama dependency
Date Mon, 17 Oct 2016 21:24:57 GMT
Tim Armstrong has posted comments on this change.

Change subject: Remove Llama dependency
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

Line 92:   21: optional i16 v_cpu_cores
> add some TODO here
Done


Line 108:   25: optional i64 rm_initial_mem = 0
> add same TODO here
Done


http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

Line 137:   V_CPU_CORES,
> add same TODO
Done


Line 153:   RM_INITIAL_MEM,
> add same TODO
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e5e21d8047097d56062ded11b0832a1d397fe0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message