impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements
Date Mon, 17 Oct 2016 20:52:49 GMT
Henry Robinson has posted comments on this change.

Change subject: Follow Apache Project Branding Requirements
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4683/1/bylaws.html
File bylaws.html:

PS1, Line 134: 
             : 
             : 
             : 
I don't quite understand this change - is all the content going in the masthead or navbar
div now?


http://gerrit.cloudera.org:8080/#/c/4683/1/downloads.html
File downloads.html:

PS1, Line 176: <div class="footer">
             :     <p class="pull-right"><img src="img/incubator.png"></p>
             : 
             :     <p>Apache Impala is an effort undergoing incubation at the Apache
Software Foundation
             :     (ASF), sponsored by the Apache Incubator PMC. Incubation is required of
all newly
             :     accepted projects until a further review indicates that the infrastructure,
             :     communications, and decision making process have stabilized in a manner
consistent
             :     with other successful ASF projects. While incubation status is not necessarily
a
             :     reflection of the completeness or stability of the code, it does indicate
that the
             :       project has yet to be fully endorsed by the ASF.</p>
             : 
             :     <p>Apache Impala, Impala, Apache, the Apache feather logo, and the
Apache Impala
             :     project logo are either registered trademarks or trademarks of The Apache
Software
             :     Foundation in the United States and other countries.
             :     </p>
             :   </div>
Can you try and keep the indentation consistent for <div>s? It's hard to see where this
lines up relative to the navbar div above.


-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message