impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself
Date Mon, 17 Oct 2016 19:07:10 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4698/1//COMMIT_MSG
Commit Message:

PS1, Line 16: This builds if I manually put hive_metastore.thrift in the right place
> I agree with the question above. Would it not be better to use the env vari
See https://gerrit.cloudera.org/#/c/4720/


PS1, Line 16: This builds if I manually put hive_metastore.thrift in the right place
> Why does this need to manually be put in the right place?
We don't have the special component tarballs for CDH6.x, so I just did this to validate that
it can build.


Line 23: 
> Since there are only a few API changes, I think it would be good if you cou
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0be6bbe76d929ceaeb2fa9ac4ebba1820c4dab7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Charlie Helin <chelin@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message