impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charlie Helin (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself
Date Mon, 17 Oct 2016 18:58:03 GMT
Charlie Helin has posted comments on this change.

Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4698/1//COMMIT_MSG
Commit Message:

PS1, Line 16: This builds if I manually put hive_metastore.thrift in the right place
> Why does this need to manually be put in the right place?
I agree with the question above. Would it not be better to use the env variables to point
to any necessary location instead and then manually assign the variables such that it builds?

That way you could separate the build into two separate steps 
1) Retrieve/locate the proper artifacts
2) Point to the location where the artifact resides


-- 
To view, visit http://gerrit.cloudera.org:8080/4698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0be6bbe76d929ceaeb2fa9ac4ebba1820c4dab7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Charlie Helin <chelin@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message