impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself
Date Mon, 17 Oct 2016 18:17:03 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself
......................................................................


Patch Set 1:

(2 comments)

Sorry for the delay.

http://gerrit.cloudera.org:8080/#/c/4698/1//COMMIT_MSG
Commit Message:

PS1, Line 16: This builds if I manually put hive_metastore.thrift in the right place
Why does this need to manually be put in the right place?


Line 23: 
Since there are only a few API changes, I think it would be good if you could add a link here
(if one exists) to the function signatures that changed, or just list them out.
It will be good to refer back to this in the case of any issues related to these new APIs
we see in testing in the future.


-- 
To view, visit http://gerrit.cloudera.org:8080/4698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0be6bbe76d929ceaeb2fa9ac4ebba1820c4dab7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Charlie Helin <chelin@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message