impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4294: Execute data load steps from within git repo.
Date Fri, 14 Oct 2016 20:40:58 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-4294: Execute data load steps from within git repo.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4726/2/buildall.sh
File buildall.sh:

PS2, Line 431:   # Data loading relies upon comparing git hashes, so we need to make sure
             :   # we're executing from within the context of the Impala repo directory.
             :   pushd "${IMPALA_HOME}"
             :   load_test_data
             :   popd
> Do you think it would make more sense to pushd in Impala/testdata/bin/check
I like having pushd/popd happen in the same script, rather than pushd in one script, and popd
in another script. If I put popd at the end of check-schema-diff.sh, that would affect the
exit code (I think, right?) and that's what we check for.


-- 
To view, visit http://gerrit.cloudera.org:8080/4726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message