impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3002/IMPALA-1473: Cardinality observability cleanup
Date Fri, 14 Oct 2016 17:48:11 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-3002/IMPALA-1473: Cardinality observability cleanup
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4679/2//COMMIT_MSG
Commit Message:

PS2, Line 7: IMPA
> nit: can you separate this into separate IMPALA-1473, sometimes ppl are gre
Done


http://gerrit.cloudera.org:8080/#/c/4679/2/shell/impala_client.py
File shell/impala_client.py:

PS2, Line 145:     # is the max over all
> I think you need to update impala_beeswax.py which duplicates this code (un
Done


http://gerrit.cloudera.org:8080/#/c/4679/2/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:

PS2, Line 25: test_merge_exchange_num_rows(s
> test_merge_exchange_num_rows
Done


PS2, Line 26: IMPALA-1473 
> I think this tests both 1473 and IMPALA-3002. Can you verify that with a pr
It does actually exercise the relevant code for IMPALA-3002 (in impala_beeswax at least),
but the result is the same with or without the fix for this particular query, so I added another
test.


-- 
To view, visit http://gerrit.cloudera.org:8080/4679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I386719370386c9cff09b8b35d15dc712dc6480aa
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message