impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <>
Subject [Impala-ASF-CR] Match .clang-format more closely to actual practice.
Date Fri, 14 Oct 2016 00:08:17 GMT
Jim Apple has submitted this change and it was merged.

Change subject: Match .clang-format more closely to actual practice.

Match .clang-format more closely to actual practice.

In order to attempt to get code like

    double VeryLongFunctionNames(double x1, double x2, double x3,
        double x4) {
      return 1.0;

rather than

    double VeryLongFunctionNames(
        double x1, double x2, double x3, double x4) {
      return 1.0;

I wrote a small set of programs to infer which .clang-format params
fit the current Impala codebase most closely; this patch is the

This patch is the best the inferencer found (while maintaining certain
enforced parameters, like 90-character lines). It is about 10% closer
to Impala's current code base than the .clang-format that is checked
in at the moment, as measured by number of lines in the diff.

Change-Id: Iccaec6c1673c3e08d2c39200b0c84437af629aed
Reviewed-by: Jim Apple <>
Tested-by: Jim Apple <>
M .clang-format
1 file changed, 35 insertions(+), 14 deletions(-)

  Jim Apple: Looks good to me, approved; Verified

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: Iccaec6c1673c3e08d2c39200b0c84437af629aed
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Tim Armstrong <>

View raw message