impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes
Date Thu, 13 Oct 2016 22:37:01 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4188: Leopard: support external Docker volumes
......................................................................


Patch Set 8:

(3 comments)

Thanks for the review, Taras. Please see patch set 8.

http://gerrit.cloudera.org:8080/#/c/4678/7/tests/comparison/leopard/impala_docker_env.py
File tests/comparison/leopard/impala_docker_env.py:

PS7, Line 142: art_command += (
> I feel like it's not elegant that we have to add another -v here. How about
Done


PS7, Line 171:   
> It's interesting that the closing brace is on a separate line. Is this some
It satisfies flake8 to switch to this style. If I join this line up to the line above and
run flake8, I get an error like this:

  impala_docker_env.py:169:9: E125 continuation line with same indent as next logical line


PS7, Line 312: '--delete -
> it's a little confusing here, why are there two single quotes followed by a
I'm gonna call line this a Casey-ism: It's so I can align the ssh options under the ssh command,
not include extra white space in the rendered Fabric command, and satisfy flake8

This:

  '       -o UserKnownHostsFile=/dev/null -p {ssh_port}" '

...causes a bunch of white space to exist in the rendered command; it can be seen when you
are running ps.

And this:

  'rsync -e "ssh [etc]" '
             '-o UserKnownHostsFile [etc]" '

... is seen by flake8 as an over-indented line and produces en error.

This seemed the easiest way to satisfy all of the above.


-- 
To view, visit http://gerrit.cloudera.org:8080/4678
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7d9d9253fcd7e3905e389ddeb1438cee3e24480
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message