impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others
Date Thu, 13 Oct 2016 07:35:03 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others
......................................................................


Patch Set 13: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4402/12/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 1522:   // prevent others from cancelling a second time
> I think it's ok the cancel fragments without the query being in error. The 
good explanation. could you put that somewhere, i agree that there's a bit of confusion around
query states


http://gerrit.cloudera.org:8080/#/c/4402/12/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

Line 321: class HS2RowOrientedResultSet : public QueryResultSet {
> I think I'll do that separately, if you agree. Although it's mostly mechani
fine by me, but please make sure to do it right after this goes in.


http://gerrit.cloudera.org:8080/#/c/4402/12/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:

Line 705:     while ((num_rows < max_rows || max_rows <= 0)
where is this being done now?


-- 
To view, visit http://gerrit.cloudera.org:8080/4402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb0064ec2f085fa3a5598ea80894fb489a01e4df
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message