impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.
Date Wed, 12 Oct 2016 21:48:59 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4259: build Impala without any test cluster setup.
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4685/6/buildall.sh
File buildall.sh:

Line 311:   "${MAKE_CMD}" ext-data-source fe
> do we need the "ext-data-source" part? the fe cmake target depends on it
We don't but otherwise it's hard to see that this actually builds both artifacts without scrounging
through CMake files (I was thinking of the ext-data-source jar as a separate build artifact
from the frontend).


-- 
To view, visit http://gerrit.cloudera.org:8080/4685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I429da7bc6681b16c07fe58bb3efac6d1a8579137
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message