impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3943: Do not throw scan errors for empty Parquet files.
Date Wed, 12 Oct 2016 05:04:54 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3943: Do not throw scan errors for empty Parquet files.

Patch Set 1:

File tests/query_test/

Line 250:     succeeds without errors irrespective of abort_on_error."""
> why even mention abort_on_error? i think that's still a legal parquet file.

Line 256:     check_call(['hdfs', 'dfs', '-copyFromLocal',
> out of scope, but would be better to have this set up as a permanent table 
Agree, out of scope. I think it is also debatable.

Imo, it's better for test infra stability to have have such one-off tables be self-contained
in the test without "polluting" the snapshot and data loading paths. Think about it this way:
Adding to the functional suite would require much more script/conf changes in several different
files and potentially cause hiccups with stale snapshots. Doesn't seem worth it if only this
single test needs those files.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I50ac3df6ff24bc5c384ef22e0f804a5132adb62e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-HasComments: Yes

View raw message