impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.
Date Wed, 12 Oct 2016 01:11:55 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4259: build Impala without any test cluster setup.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4685/1/buildall.sh
File buildall.sh:

PS1, Line 386: 5
> If a more meaningful test could be substituted, that would be great. If not
Done


PS1, Line 424: start_test_cluster
> I don't want to hold up this review, since this is a clear improvement on w
I think that would be helpful in many cases if it brought up an Impala cluster. I run ./buildall.sh
-debug -noclean -notests -skiptests -ninja && start-impala-cluster.py all the time.

The problem that I see is that there are a number of consumers of this script that assume
passing -notests is sufficient to only build Impala and not try to start a test cluster. Part
of what I was hoping to achieve is to do even less in that case - avoid creating cluster configs,
etc.

Do you think it would be helpful to add a new flag to start the cluster? E.g. -start_impala_cluster?

I think we could definitely remove the Kerberos special-case - no reason it should start a
cluster then when the other modes don't.


-- 
To view, visit http://gerrit.cloudera.org:8080/4685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I429da7bc6681b16c07fe58bb3efac6d1a8579137
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message