impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables
Date Tue, 11 Oct 2016 23:02:56 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

Patch Set 4:

(1 comment)
File tests/common/

PS1, Line 54:   def auto_create_db(cls):
            :     return True
            :   @classmethod
            :   def get_db_name(cls):
            :     # When py.test runs with the xdist plugin, several processes are started
and each
            :     # process runs some partition of the tests. It's possible that multiple
            :     # will call this method. A random value is generated so the processes won't
            :     # to use the same database at the same time. The value is cached so within
a single
            :     # process the same database name is always used for the class. This doesn't
need to
            :     # be thread-safe since multi-threading is never used.
            :     if not cls.__DB_NAME
> Duno. I'll check with Michael.
To answer this: It looks like this provides the same functionality as unique_database, but
over a different channel (the conn/cursor fixtures in The design of KuduTestSuite
and dependents are so different than most of our test cases. While switching to unique_database
can be done, it will be nontrivial, and would require a bit of a change in test design.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b9d51b2720ab57649abdb7d5c710ea04ff50dc1
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-HasComments: Yes

View raw message