impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1473: Incorrect cardinality in exec summary for exchange
Date Tue, 11 Oct 2016 22:44:23 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-1473: Incorrect cardinality in exec summary for exchange
......................................................................


Patch Set 1:

> (3 comments)
 > 
 > Thanks!
 > 
 > While this fixes the summary, I'm still seeing the wrong result in
 > the profile's coordinator RowsProduced. (I had mentioned that in
 > the JIRA summary). We should fix up these things at the same time
 > since it's confusing if the info doesn't make sense.
 > 
 > When I ran the query in the test I found:
 > Coordinator Fragment F02:(Total: 271.450ms, non-child: 2.134ms, %
 > non-child: 0.79%)
 > MemoryUsage(500.000ms): 16.06 KB, 20.08 KB
 > - AverageThreadTokens: 0.00
 > - BloomFilterBytes: 0
 > - PeakMemoryUsage: 20.08 KB (20560)
 > - PerHostPeakMemUsage: 0
 > - PrepareTime: 121.367us
 > - RowsProduced: 0 (0)
 > 
 > 
 > RowsProduced should be 5. Not sure why it's 0, but the
 > PlanFragmentExecutor::GetNext() calls ExchangeNode::GetNext() and
 > then sets
 > 
 > COUNTER_ADD(rows_produced_counter_, row_batch_->num_rows());
 > 
 > 
 > Which it looks like isn't coming back or isn't being set properly
 > by the ExchangeNode for some reason.

Forgot to mention though that you'll probably need to fix IMPALA-3002 at the same time. That
seems like the right thing to do anyway- it makes sense to fix all these known broken 'num
rows' issues at the same time.

-- 
To view, visit http://gerrit.cloudera.org:8080/4679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I386719370386c9cff09b8b35d15dc712dc6480aa
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message