impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.
Date Tue, 11 Oct 2016 22:04:41 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4259: build Impala without any test cluster setup.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4685/1/buildall.sh
File buildall.sh:

PS1, Line 386: 5
> Where does the 5 come from? E.g., in my dev environment, there are 996 item
No idea, I just moved the preexisting code. 

I kind of feel like we should just remove this check since I'm not sure how useful it really
is.


PS1, Line 424: start_test_cluster
> This only just occurred to me, but is it weird that buildall.sh doesn't act
It is a little weird. I guess because the test or data loading scripts want to restart Impala
anyway.

I renamed to start_test_cluster_dependencies - hopefully that's clearer.


-- 
To view, visit http://gerrit.cloudera.org:8080/4685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I429da7bc6681b16c07fe58bb3efac6d1a8579137
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message