impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4259: build Impala without any test cluster setup.
Date Tue, 11 Oct 2016 21:52:12 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-4259: build Impala without any test cluster setup.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4685/1/buildall.sh
File buildall.sh:

PS1, Line 386: 5
Where does the 5 come from? E.g., in my dev environment, there are 996 items inside of test-warehouse.


PS1, Line 424: start_test_cluster
This only just occurred to me, but is it weird that buildall.sh doesn't actually start impala
if no tests are run, since calling start-impala-cluster.py seems to be delegated to run-all-tests.sh
and create-load-data.sh (except in the case of a kerberized setup)? This was true even before
this patch.

It seems a bit odd to be me at any rate. Is it by design? Or oversight? Should start_test_cluster
be called start_hadoop_cluster, or something similar, to more clearly indicate that what is
being started are all of the other non-impala hadoop components.


-- 
To view, visit http://gerrit.cloudera.org:8080/4685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I429da7bc6681b16c07fe58bb3efac6d1a8579137
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message