impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3348: Avoid per-slot check vector size in KuduScanner
Date Tue, 11 Oct 2016 20:02:16 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3348: Avoid per-slot check vector size in KuduScanner
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4688/1/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

Line 241:   for (int i = 0; i < num_string_slots_; ++i) {
> Wouldn't storing the size here have the same effect, i.e.:
Not exactly the same - it still has to be called for every tuple. That's probably fine, but
let's ask Mostafa since he found this issue in his tests. This may go away soon if the tuple
layout changes make it in.


-- 
To view, visit http://gerrit.cloudera.org:8080/4688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie76d33c3d00e3be6d238226d28c4100bb65aac58
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message