impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.
Date Mon, 10 Oct 2016 20:43:14 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

Patch Set 14:


File common/thrift/CatalogObjects.thrift:

Line 366
> there's a TTableDescriptor.table_id which deserves a comment (clarify that 
File fe/src/main/java/org/apache/impala/analysis/

Line 294:     // same version of table in a single query, we cache all referenced tables here.
> "of a table"

Yes. but I think we definitely should not cache Db at this time since we maybe expecting a
"complete" table arriving. For others, I am not sure about the others. maybe we should consider
those in another Jira?

Line 2284:    * the table has not yet been loaded in the local catalog cache.
> update comment: effect on referencedTables_
File fe/src/main/java/org/apache/impala/analysis/

PS14, Line 44: Table targetTable_
> will update comment. basically this is used to reserve id 0 to table sink b
Done, but may need reword?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 14
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Huaisi Xu <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message