impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo
Date Mon, 10 Oct 2016 18:18:58 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4047: Remove occurrences of 'CDH'/'cdh' from repo
......................................................................


Patch Set 8:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4187/8/be/src/util/redactor.detail.h
File be/src/util/redactor.detail.h:

PS8, Line 23: /// TODO: Replace the above link with the public version once it is available.
> can remove
Done


http://gerrit.cloudera.org:8080/#/c/4187/8/be/src/util/redactor.h
File be/src/util/redactor.h:

PS8, Line 23: /// TODO: Replace the above link with the public version once it is available.
> can remove
Done


http://gerrit.cloudera.org:8080/#/c/4187/8/fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java
File fe/src/main/java/org/apache/impala/catalog/PartitionStatsUtil.java:

PS8, Line 93: as of Impala 2.0)
> Which HIVE version?
I added to the comment, Impala 2.0 was shippped with Hive 0.13


http://gerrit.cloudera.org:8080/#/c/4187/8/tests/comparison/leopard/impala_docker_env.py
File tests/comparison/leopard/impala_docker_env.py:

PS8, Line 35: DEFAULT_DOCKER_IMAGE_NAME = 'cloudera/impala-dev'
> Can you file a bug to the public issue tracker saying some community member
Done, IMPALA-4267


-- 
To view, visit http://gerrit.cloudera.org:8080/4187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message