impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Huaisi Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.
Date Fri, 07 Oct 2016 23:12:17 GMT
Huaisi Xu has posted comments on this change.

Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.
......................................................................


Patch Set 12:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/4349/12//COMMIT_MSG
Commit Message:

Line 7: IMPALA-1702: Enforce table level consistency
> Enforce single-table consistency in query analysis.
Done


Line 10: new update arrives at frontend while queries are being
> new updates arrive at the frontend
Done


Line 12: to a different version, and different table may share the
> different tables
Done


Line 14: another in the backend table map.
> another one in the thrift descriptor table sent to the backend.
Done


Line 16: This commit removes table id from the Table object; instead
> removes the table if from the catalog Table object
Done


Line 17: frontend assigns a unique id to each table just before
> the frontend assigns a unique id to each table in DescriptorTable.toThrift(
Done


http://gerrit.cloudera.org:8080/#/c/4349/12/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java:

Line 417:    * Validates that all tables in the descriptor table of 'request' have a unique
id.
> Validates that all tables in the descriptor table of 'request' have a uniqu
Done


Line 422:     if (execRequest.isSetDesc_tbl()) {
> I will merge that to line 420 next patch..
Done


Line 424:       if (descTbl.isSetTableDescriptors()) {
> and merge this
Done


Line 434:         for (TTupleDescriptor tupleDesc: descTbl.tupleDescriptors) {
> also check the table sink's id (if there is a sink)
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message