impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service
Date Thu, 06 Oct 2016 23:15:35 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-1702: Enforce table level consistency accross service

Patch Set 9:

File fe/src/main/java/org/apache/impala/analysis/

Line 295:     private final HashMap<TableName, Table> referencedTables_ = Maps.newHashMap();
> Is this change (maintaining referenced tables cache) still required with th
I agree it's not required specifically to fix the table id problem, but it generally seems
saner to have the guarantee. I think we can probably come up with scenarios where not having
this guarantee can cause hard-to-debug problems (which are different than the table id problems).
File fe/src/main/java/org/apache/impala/analysis/

Line 164:     HashMap<TableName, Table> referencedTables = Maps.newHashMap();
> Same question as in referencedTables_ in Analyzer. Assuming we want to reta
The map is only for validation purposes.

The purpose of this map is to check that we've gotten tables from Analyzer.referencedTables_
in all code paths, so it doesn't make sense to validate with Analyzer.referencedTables_ itself.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Huaisi Xu <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message