impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Burkert (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node
Date Thu, 06 Oct 2016 22:27:42 GMT
Dan Burkert has posted comments on this change.

Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with
Kudu scan node
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4639/1/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:

PS1, Line 137: KUDU_RETURN_IF_ERROR(kudu::client::KuduScanToken::DeserializeIntoScanner(
             :       scan_node_->kudu_client(), scan_token, &scanner),
> @Kudu-team: Is this worth accounting for?
This operation doesn't require any RPCs, so it should be fast.


PS1, Line 159: scanner_->Close();
> @Kudu-team: Is this worth accounting for?
If the scan node doesn't scan until completion, calling Close may issue an async RPC to the
tserver to close the scanner.  However, I doubt y'all don't finish the scan, and the RPC is
not waited on, so this should be fast.


-- 
To view, visit http://gerrit.cloudera.org:8080/4639
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0c793930799fdcaff53e705f94b52cadac2f53a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Dan Burkert <dan@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message