impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service
Date Thu, 06 Oct 2016 14:53:17 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-1702: Enforce table level consistency accross service

Patch Set 8:

File fe/src/main/java/org/apache/impala/analysis/

Line 154:   // Connect tupleDescriptors to tableDescriptors with unique table ids.
Use /** */ style comment

Line 156:   // table are the same instances.
are the same instance -> refer to the same table instance.

Line 162:     HashMap<TableName, Table> referencedTables = Maps.newHashMap();
also add targetTable_ to this map if needed

Line 173:         Table oldTable = referencedTables.get(tblName);
"old" seems a little odd here, maybe something like checkTable?
File fe/src/main/java/org/apache/impala/analysis/

Line 49:   public TableName(Table table) {
Table.getTableName() does the same thing
File fe/src/test/java/org/apache/impala/planner/

Line 421:    * 2. All tables reference to the same version of table in Analyzer::getTable().
DescriptorTable.toThrift() already does this, so we don't need to check it again here.

We only need to validate that table ids are unique here.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Huaisi Xu <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message