impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend
Date Wed, 05 Oct 2016 17:32:45 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances
on a single backend
......................................................................


Patch Set 18:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4054/17/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

PS17, Line 483:   // initialize progress updater
              :   const string& str = Substitute("Query $0", PrintId(query_id_));
              :   progress_.Init(str, schedule_.num_scan_ranges());
why was this wrong before? If there are no remote fragments I'd imagine GetTotalFInstances
would return 1, and in PrepareCoordFragment() we should be setting the state at idx 0.


http://gerrit.cloudera.org:8080/#/c/4054/18/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

PS18, Line 643: fragment_instance_states_.push_back(coord_state);
DCHECK that this has size 1 after this


-- 
To view, visit http://gerrit.cloudera.org:8080/4054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I240445199e22f009f4e72fdb8754eb8d77e3d680
Gerrit-PatchSet: 18
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message