impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load
Date Tue, 04 Oct 2016 21:45:23 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-3983: Delete function jar resources after load
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4617/1//COMMIT_MSG
Commit Message:

Line 9: Catalog copies the UDF jar files to local file system for loading
The Catalog ... the local file system... to load the Java UDF classes for validation purposes.


Line 10: the Java UDF classes. However we don't seem to be cleaning them up
However, we do not clean them up


http://gerrit.cloudera.org:8080/#/c/4617/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

Line 156:   private static final String LOCAL_LIBRARY_PATH = new String("file://" +
Shouldn't we use the -local_library_dir here or is that a different JIRA?


-- 
To view, visit http://gerrit.cloudera.org:8080/4617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f9dedb5b342415380c83e61a72eb497371a8199
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message