impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view
Date Tue, 04 Oct 2016 20:25:12 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4042: count(distinct NULL) fails on a view
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4600/3//COMMIT_MSG
Commit Message:

Line 7: IMPALA-4042: count(distinct NULL) fails on a view
This should describe the fix, not the problem. In particular, it should not be a copy of the
JIRA title, unless the JIRA title is already an appropriate description of the fix.

Something like:

Preserve root types when substituting grouping exprs.


http://gerrit.cloudera.org:8080/#/c/4600/3/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java
File fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java:

Line 339:     // preserveRootType is set to true because groupingExprs_ would
shorter:

Preserve the root type for NULL literals.


http://gerrit.cloudera.org:8080/#/c/4600/3/testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test
File testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test:

Line 1066: # IMPALA-4042: count(distinct NULL) fails on a view
move into distinct.test


-- 
To view, visit http://gerrit.cloudera.org:8080/4600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf3b4511234e473e5b9548fbf3e97f333c9980f1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-HasComments: Yes

Mime
View raw message