impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4213: Planner not pushing some Kudu predicates
Date Tue, 04 Oct 2016 03:46:15 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4213: Planner not pushing some Kudu predicates
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4613/1/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java
File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java:

Line 126:       predicate.foldConstantChildren(analyzer);
I think foldConstantChildren() subtly does not do what we really want here. I'd suggest fixing
foldConstantchildren() to reset() and analyze() the expr again. Note that the comment on foldConstantChildren()
explicitly mentions with rather strange behavior.


-- 
To view, visit http://gerrit.cloudera.org:8080/4613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bab22d90ee00a054c847de6c734b4f24a3f5a85
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message