impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Match .clang-format more closely to actual practice.
Date Mon, 03 Oct 2016 21:21:07 GMT
Jim Apple has posted comments on this change.

Change subject: Match .clang-format more closely to actual practice.
......................................................................


Patch Set 2:

> > I'm not sure I understand why a person might want to run the
 > inferencer again, even if the relationship between config files and
 > the induced changes are sometimes confusing.
 > 
 > If I don't understand how to get the results I want (because the
 > formatter has become a black box), the only recourse left to me is
 > to ask a machine to do it for me - just like has happened here.

I think I understand what you mean. Unfortunately, I think that's an issue with the number
of clang-format options. I think we will face that issue with or without inference.

-- 
To view, visit http://gerrit.cloudera.org:8080/4590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccaec6c1673c3e08d2c39200b0c84437af629aed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message