impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Match .clang-format more closely to actual practice.
Date Mon, 03 Oct 2016 21:16:57 GMT
Jim Apple has posted comments on this change.

Change subject: Match .clang-format more closely to actual practice.
......................................................................


Patch Set 2:

> Do you understand the relationship between the resulting
 > .clang-format file and the changes in formatting?

None of the config options is by itself confusing, but some of the diffs are. This one I don't
understand:

https://gerrit.cloudera.org/#/c/4591/1..2/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java


 > I would rather
 > not get into a situation where I have to re-run an inferencer to
 > make small changes to the format file because we don't understand
 > the dependency of the outputs on the inputs.

I'm not sure I understand why a person might want to run the inferencer again, even if the
relationship between config files and the induced changes are sometimes confusing.

-- 
To view, visit http://gerrit.cloudera.org:8080/4590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccaec6c1673c3e08d2c39200b0c84437af629aed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message