impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4239: fix buffer pool test failures in release build
Date Mon, 03 Oct 2016 20:43:38 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4239: fix buffer pool test failures in release build
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4596/1/be/src/testutil/death-test-util.h
File be/src/testutil/death-test-util.h:

Line 34: // Don't execute death tests in release builds for consistency with debug builds
- in
The "for consistency with debug builds" part is confusing, can you rephrase this comment to
be more similar to your commit msg? Better to be specific here.


-- 
To view, visit http://gerrit.cloudera.org:8080/4596
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia560e702ecac2d29dc72f444645d5a91743c95e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message