impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous Coward (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view
Date Mon, 03 Oct 2016 20:27:29 GMT
Anonymous Coward #216 has posted comments on this change.

Change subject: IMPALA-4042: count(distinct NULL) fails on a view
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4600/2/fe/src/main/java/org/apache/impala/analysis/Expr.java
File fe/src/main/java/org/apache/impala/analysis/Expr.java:

Line 734:     if (smap == null || this instanceof NullLiteral) return result;
> This invalidates the comment above that when smap is null, this function is
I thought that NullLiteral would not require substitution and, hence, simply clone/return
for NullLiteral. Could you explain when NullLiteral requires substitution, for me to have
better understanding on the code?

In the meantime, let me follow source code to figure out where I can leverage preserveRootType.


-- 
To view, visit http://gerrit.cloudera.org:8080/4600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf3b4511234e473e5b9548fbf3e97f333c9980f1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <yonghyun@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #216
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message