Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 94852200B8B for ; Tue, 20 Sep 2016 02:10:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 93003160ADC; Tue, 20 Sep 2016 00:10:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8DFA160ACC for ; Tue, 20 Sep 2016 02:10:34 +0200 (CEST) Received: (qmail 84380 invoked by uid 500); 20 Sep 2016 00:10:34 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 84368 invoked by uid 99); 20 Sep 2016 00:10:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Sep 2016 00:10:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 59F38C138C for ; Tue, 20 Sep 2016 00:10:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.702 X-Spam-Level: X-Spam-Status: No, score=-0.702 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera-com.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id tUHFwxcPB5l1 for ; Tue, 20 Sep 2016 00:10:31 +0000 (UTC) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 308415FD39 for ; Tue, 20 Sep 2016 00:10:31 +0000 (UTC) Received: by mail-io0-f182.google.com with SMTP id q92so4279936ioi.1 for ; Mon, 19 Sep 2016 17:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudera-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FuAX5hai3P9rvqyvI/5TBvy5EO5uni3COGuL0QGEYKg=; b=vHNpTtLXmOOazqABfjcv6OKQ02nwZvHAbBKj1sBLDoUQr9VUHBbyJMrfYghHPBV08l 1mEmVlOV0Hh7q/yjk5wrZ/92OJ7oKWCzzwsnGuFKKnH7SgwKA0U8pSUdisO845G2nV/i nno/Zm15oUFeSKb/MccRCT0pInviaiaQb0KxrFIQ+vT0nPDoJZXZISt2i7NtFv7fCBS6 y6SgU3B4U9IxOjcP5PuLcCzKk8eD94/H8Dw/OZ+A/mOEWzoWYcytRTH1yQsIC6f02Pyh qqpRif14hPzKEAEkVfx/K1ocf8nLUFEL48pTGCSlIm7tWM0i/dn84nZ7+R8Kv8EeYhm3 j67Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FuAX5hai3P9rvqyvI/5TBvy5EO5uni3COGuL0QGEYKg=; b=G0XvnutxlVfgG8DCqTQKX+VlU3HTdE2QZ8XR1Nq0XC2ujq4Nkv03/JXsF0yN94tnQU rmHmgeu8cnasfJhn0b+UuB42l+Nj/yD7lF3s7eUPrcWQW0i3qWmdSVjKP+fvhXGLOQzU xJQ9uHba4/ho5o5ddydONmEvSrOPi2wgE7RqVdtkpq7BHzxGhnNXBFtONiUtxUHjqQvZ G8uAIEhBgFp2aibi4OhZi4FRRnmghEnwAq7ZznVwVY5rd+S4rF27Dg9fSxaeOY3qOnvy ZudaY2FsBuGcUNLrN2Zvp9dPFqO6znOgzBh/MwUT9MWWYPJeSodPiqDlQPSlptROsSUF EEfw== X-Gm-Message-State: AE9vXwN+NM2gZo+ae3aYuRSCe6SESssVCUhXDG7steZOAaNTzxjHROaXr4vj3yGMdx+OvBDa8jfPljHRX92cn2Oy X-Received: by 10.107.183.9 with SMTP id h9mr37919474iof.192.1474330230628; Mon, 19 Sep 2016 17:10:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.219.8 with HTTP; Mon, 19 Sep 2016 17:10:10 -0700 (PDT) In-Reply-To: References: <201609192319.u8JNJBew006846@ip-10-146-233-104.ec2.internal> From: Matthew Jacobs Date: Mon, 19 Sep 2016 17:10:10 -0700 Message-ID: Subject: Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support. To: Henry Robinson Cc: impala-cr , reviews@impala.incubator.apache.org, Taras Bobrovytsky , Marcel Kornacker Content-Type: text/plain; charset=UTF-8 archived-at: Tue, 20 Sep 2016 00:10:35 -0000 Yup, sure thing On Mon, Sep 19, 2016 at 4:54 PM, Henry Robinson wrote: > Sounds good - if it's ok by you, will do in a separate commit since the > first one is well into GVO-land... > > On 19 September 2016 at 16:19, Matthew Jacobs (Code Review) > wrote: >> >> Matthew Jacobs has posted comments on this change. >> >> Change subject: IMPALA-4160: Remove Llama support. >> ...................................................................... >> >> >> Patch Set 5: >> >> (3 comments) >> >> a few more small things to remove >> >> http://gerrit.cloudera.org:8080/#/c/4445/5/testdata/cluster/admin >> File testdata/cluster/admin: >> >> PS5, Line 82: export LLAMA_WEBUI_PORT=1501 # same as default >> remove >> >> >> PS5, Line 262: # Escape the first : to workaround >> https://jira.cloudera.com/browse/CDH-16840 >> : >> LLAMA_PORT_MAPPINGS+="$HADOOP_HOSTNAME\\:$DATANODE_PORT=" >> : >> LLAMA_PORT_MAPPINGS+="$HADOOP_HOSTNAME:$NODEMANAGER_PORT >> We can probably remove these >> >> >> PS5, Line 266: LLAMA_PORT_MAPPINGS >> this too >> >> >> -- >> To view, visit http://gerrit.cloudera.org:8080/4445 >> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings >> >> Gerrit-MessageType: comment >> Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef >> Gerrit-PatchSet: 5 >> Gerrit-Project: Impala-ASF >> Gerrit-Branch: master >> Gerrit-Owner: Henry Robinson >> Gerrit-Reviewer: Henry Robinson >> Gerrit-Reviewer: Marcel Kornacker >> Gerrit-Reviewer: Matthew Jacobs >> Gerrit-Reviewer: Taras Bobrovytsky >> Gerrit-HasComments: Yes > > > > > -- > Henry Robinson > Software Engineer > Cloudera > 415-994-6679