Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3FF0E200B8B for ; Tue, 20 Sep 2016 01:55:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3E6CE160ADC; Mon, 19 Sep 2016 23:55:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8188B160ACC for ; Tue, 20 Sep 2016 01:55:01 +0200 (CEST) Received: (qmail 50261 invoked by uid 500); 19 Sep 2016 23:55:00 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 50212 invoked by uid 99); 19 Sep 2016 23:55:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Sep 2016 23:55:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 04DB61804C1 for ; Mon, 19 Sep 2016 23:55:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.279 X-Spam-Level: * X-Spam-Status: No, score=1.279 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera-com.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id TpPRsr91oqFH for ; Mon, 19 Sep 2016 23:54:58 +0000 (UTC) Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 1598D5FD39 for ; Mon, 19 Sep 2016 23:54:58 +0000 (UTC) Received: by mail-lf0-f43.google.com with SMTP id l131so567068lfl.2 for ; Mon, 19 Sep 2016 16:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudera-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=V9i4LLBN4sMsMX2CateiR1OELkBnSffpajkzhj21VMY=; b=nNmixHS2bv5DZrDLLQWc2cBPcEPBvDyzEvCQIkp5iDiCGBexoakP7Ne4+j7kEAAre9 ae0mNv9UF8735UnBXOlhYlSTNZDJrooPaAn3ssWkOBxz0USmFsDH+FhqQ+nZS6jJJ+71 Wd84lrhqLIodpzdGincwWOKOOr37ufb143zXb41iwT0clgAV4AyKlNejXzk0dpk43V49 Zj4r6lTtiHvG6A2ke7hms1DIIHK2ylYomYgpiYpj1PNbgCQrGgmRORYOGx7xLBPq3lJB x/q662+hWF6i3Bp6M4Vruw1PrFvnX0JTmwHzbftx1yoBsY7VyPDvjqO/fl9oHbdIWunT /q/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=V9i4LLBN4sMsMX2CateiR1OELkBnSffpajkzhj21VMY=; b=I/W2xn4uitxNmOkdUKSzZPwXLuFNELjHagBEc3Y6SzcZ0vDbGOVgkzTE3KcqntCKUK NPHXAr/DPqCWAXSI4nB9pIlYjomh7DIj+5iBY64/1ikat6Wbq+ocuoawH+llzNPf4FkJ qp5PpTNtttV/RIQUsfErE2bD5OzyVQha/BLy555YyVGTPWRvQkQ99/3yBR+6EA63JIlO DSeQ8orHob5Bp1k6oVRRAZELLXEzAHSPIF/RWY178wFhjiRZpsgP/QcVqiPvk7M17ktI zORD9R80MA0p+rNixHipHCA/4BlFq+G3fLGm9PUcm1OZfMyfLcD2mU3OXyVtKq4aeMlb qHeg== X-Gm-Message-State: AE9vXwNyBWaO6c832AhZQGKN92ofLOhctTWnggahxBDO/7OZ97exytLgVYLBVRb3lM0H2vgG5zGJKP/g8PBmOL/q X-Received: by 10.46.33.4 with SMTP id h4mr7961585ljh.70.1474329291241; Mon, 19 Sep 2016 16:54:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.29.146 with HTTP; Mon, 19 Sep 2016 16:54:30 -0700 (PDT) In-Reply-To: <201609192319.u8JNJBew006846@ip-10-146-233-104.ec2.internal> References: <201609192319.u8JNJBew006846@ip-10-146-233-104.ec2.internal> From: Henry Robinson Date: Mon, 19 Sep 2016 16:54:30 -0700 Message-ID: Subject: Re: [Impala-ASF-CR] IMPALA-4160: Remove Llama support. To: Matthew Jacobs Cc: impala-cr , reviews@impala.incubator.apache.org, Taras Bobrovytsky , Marcel Kornacker Content-Type: multipart/alternative; boundary=001a1142b534afd33d053ce50927 archived-at: Mon, 19 Sep 2016 23:55:02 -0000 --001a1142b534afd33d053ce50927 Content-Type: text/plain; charset=UTF-8 Sounds good - if it's ok by you, will do in a separate commit since the first one is well into GVO-land... On 19 September 2016 at 16:19, Matthew Jacobs (Code Review) < gerrit@cloudera.org> wrote: > Matthew Jacobs has posted comments on this change. > > Change subject: IMPALA-4160: Remove Llama support. > ...................................................................... > > > Patch Set 5: > > (3 comments) > > a few more small things to remove > > http://gerrit.cloudera.org:8080/#/c/4445/5/testdata/cluster/admin > File testdata/cluster/admin: > > PS5, Line 82: export LLAMA_WEBUI_PORT=1501 # same as default > remove > > > PS5, Line 262: # Escape the first : to workaround > https://jira.cloudera.com/browse/CDH-16840 > : LLAMA_PORT_MAPPINGS+="$HADOOP_ > HOSTNAME\\:$DATANODE_PORT=" > : LLAMA_PORT_MAPPINGS+="$HADOOP_ > HOSTNAME:$NODEMANAGER_PORT > We can probably remove these > > > PS5, Line 266: LLAMA_PORT_MAPPINGS > this too > > > -- > To view, visit http://gerrit.cloudera.org:8080/4445 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef > Gerrit-PatchSet: 5 > Gerrit-Project: Impala-ASF > Gerrit-Branch: master > Gerrit-Owner: Henry Robinson > Gerrit-Reviewer: Henry Robinson > Gerrit-Reviewer: Marcel Kornacker > Gerrit-Reviewer: Matthew Jacobs > Gerrit-Reviewer: Taras Bobrovytsky > Gerrit-HasComments: Yes > -- Henry Robinson Software Engineer Cloudera 415-994-6679 --001a1142b534afd33d053ce50927--