Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B587A200B9B for ; Wed, 28 Sep 2016 06:59:42 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B40D2160AE5; Wed, 28 Sep 2016 04:59:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 08793160AD2 for ; Wed, 28 Sep 2016 06:59:41 +0200 (CEST) Received: (qmail 59932 invoked by uid 500); 28 Sep 2016 04:59:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 59906 invoked by uid 99); 28 Sep 2016 04:59:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Sep 2016 04:59:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 86BEA1A5E81 for ; Wed, 28 Sep 2016 04:59:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7n4bxs3fSJ8R for ; Wed, 28 Sep 2016 04:59:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id AB0695FBB7 for ; Wed, 28 Sep 2016 04:59:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8S4xaVo031428; Wed, 28 Sep 2016 04:59:36 GMT Message-Id: <201609280459.u8S4xaVo031428@ip-10-146-233-104.ec2.internal> Date: Wed, 28 Sep 2016 04:59:36 +0000 From: "Juan Yu (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Mostafa Mokhtar , Chen Huang , Alex Behm , Dan Hecht , Tim Armstrong Reply-To: jyu@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4026=3A_Implement_double-buffering_for_BlockingQueue=0A?= X-Gerrit-Change-Id: Ib9f4cf351455efefb0f3bb791cf9bc82d1421d54 X-Gerrit-ChangeURL: X-Gerrit-Commit: adf3607c249d9994f1d98c73fffb04ed08a15fc9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 28 Sep 2016 04:59:42 -0000 Juan Yu has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: PS9, Line 188: Queue Could you specify which queue this is? will help people understand what's the metric for. -- To view, visit http://gerrit.cloudera.org:8080/4350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4cf351455efefb0f3bb791cf9bc82d1421d54 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Chen Huang Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes