Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B6127200B8E for ; Mon, 26 Sep 2016 22:49:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B4E99160ACA; Mon, 26 Sep 2016 20:49:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06E36160AC8 for ; Mon, 26 Sep 2016 22:49:27 +0200 (CEST) Received: (qmail 67499 invoked by uid 500); 26 Sep 2016 20:49:27 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 67488 invoked by uid 99); 26 Sep 2016 20:49:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Sep 2016 20:49:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4B2FAC0E9E for ; Mon, 26 Sep 2016 20:49:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Wow8DorWDz6a for ; Mon, 26 Sep 2016 20:49:24 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 6E1DC5F4E5 for ; Mon, 26 Sep 2016 20:49:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8QKnNPo022149; Mon, 26 Sep 2016 20:49:23 GMT Message-Id: <201609262049.u8QKnNPo022149@ip-10-146-233-104.ec2.internal> Date: Mon, 26 Sep 2016 20:49:23 +0000 From: "Jim Apple (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Alex Behm , Jim Apple , Michael Brown Reply-To: jbapple@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4047=3A_DO_NOT_SUBMIT_Highlight_all_occurrences_of_CDH/cdh=0A?= X-Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8 X-Gerrit-ChangeURL: X-Gerrit-Commit: bbfe332d308612727a3bd3a5e81394590314f69b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 26 Sep 2016 20:49:28 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4187/3/bin/impala-config.sh File bin/impala-config.sh: Line 144 > What are we going to do with this one? It looks rather prominent to me. There are so many different things we are doing with different "CDH"s, it might make sense to split this up into many small pieces. A quick grep shows me that this is mainly used as the name of a directory. I think we can just remove that from the directory name, but this might be easier to see in its own commit. -- To view, visit http://gerrit.cloudera.org:8080/4187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb37e2ef0cd9fa0e581d359c5dd3db7812b7b2c8 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes