Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 61D80200B8E for ; Mon, 26 Sep 2016 19:55:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 60131160AE3; Mon, 26 Sep 2016 17:55:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A629A160AC8 for ; Mon, 26 Sep 2016 19:55:07 +0200 (CEST) Received: (qmail 7951 invoked by uid 500); 26 Sep 2016 17:55:06 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 7938 invoked by uid 99); 26 Sep 2016 17:55:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Sep 2016 17:55:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2ECE11A05B1 for ; Mon, 26 Sep 2016 17:55:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 481n4Kq_Xjos for ; Mon, 26 Sep 2016 17:55:04 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 2B8C35FC3C for ; Mon, 26 Sep 2016 17:55:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8QHt3Lf016159; Mon, 26 Sep 2016 17:55:03 GMT Message-Id: <201609261755.u8QHt3Lf016159@ip-10-146-233-104.ec2.internal> Date: Mon, 26 Sep 2016 17:55:03 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Matthew Jacobs , Dan Hecht , Juan Yu Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4187=3A_Switch_RPC_latency_metrics_to_histograms=0A?= X-Gerrit-Change-Id: I9ba6d4270dd5676eeeff35ad8d9dc5dcddd95e34 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2dd6b219cd8bfbf775c84887f9ec2758bdf868bb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 26 Sep 2016 17:55:08 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms ...................................................................... Patch Set 4: Code-Review+2 Carry +2, made Matt's suggested changes as well. -- To view, visit http://gerrit.cloudera.org:8080/4516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ba6d4270dd5676eeeff35ad8d9dc5dcddd95e34 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No