Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AE814200B8E for ; Mon, 26 Sep 2016 18:44:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ACF25160ACA; Mon, 26 Sep 2016 16:44:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F2D9E160AC8 for ; Mon, 26 Sep 2016 18:44:07 +0200 (CEST) Received: (qmail 93138 invoked by uid 500); 26 Sep 2016 16:44:07 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 93123 invoked by uid 99); 26 Sep 2016 16:44:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Sep 2016 16:44:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 07878C1DCB for ; Mon, 26 Sep 2016 16:44:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 0ZLzZLiXS6BB for ; Mon, 26 Sep 2016 16:44:03 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 300515FBB4 for ; Mon, 26 Sep 2016 16:44:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8QGi1Nw014287; Mon, 26 Sep 2016 16:44:01 GMT Message-Id: <201609261644.u8QGi1Nw014287@ip-10-146-233-104.ec2.internal> Date: Mon, 26 Sep 2016 16:44:01 +0000 From: "Jim Apple (Code Review)" To: Youwei Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , Mostafa Mokhtar Reply-To: jbapple@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-889=3A_Add_support_for_an_ISO-SQL_compliant_trim=28=29_function=2E=0A?= X-Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602 X-Gerrit-ChangeURL: X-Gerrit-Commit: bba2b4d31450a07fdf0c977e4285663b053155a2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 26 Sep 2016 16:44:08 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit Message: Line 10: Purpose: Removes all instances of one or more characters from the > Greetings, Jim. Please look at invisible_functions, line 672 of that file. -- To view, visit http://gerrit.cloudera.org:8080/4474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Youwei Wang Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Youwei Wang Gerrit-HasComments: Yes