Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5A91A200B96 for ; Thu, 22 Sep 2016 02:18:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 590CE160ADE; Thu, 22 Sep 2016 00:18:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9F548160ADB for ; Thu, 22 Sep 2016 02:18:05 +0200 (CEST) Received: (qmail 24797 invoked by uid 500); 22 Sep 2016 00:18:04 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 24785 invoked by uid 99); 22 Sep 2016 00:18:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2016 00:18:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 465231A569B for ; Thu, 22 Sep 2016 00:18:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5AheXNGTFLu8 for ; Thu, 22 Sep 2016 00:18:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 11E635FBB5 for ; Thu, 22 Sep 2016 00:18:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8M0I0rs030427; Thu, 22 Sep 2016 00:18:00 GMT Message-Id: <201609220018.u8M0I0rs030427@ip-10-146-233-104.ec2.internal> Date: Thu, 22 Sep 2016 00:18:00 +0000 From: "Matthew Jacobs (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4011=3A_Remove_/_reword_messages_when_statestore_messages_are_late=0A?= X-Gerrit-Change-Id: I09c7fa4a94065965e5cb83a3b183b2175f8b45fc X-Gerrit-ChangeURL: X-Gerrit-Commit: 5b0611c7fb49b029d8ffd01681e6817bc6475bb2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 22 Sep 2016 00:18:06 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4500/1/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: PS1, Line 630: const string& msg = Substitute( : "Missed subscriber ($0) $1 d > Ok, although bear in mind that CM references aren't verboten just because t Oh ok, I assumed CM refs would be out. I'm fine either way then. -- To view, visit http://gerrit.cloudera.org:8080/4500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c7fa4a94065965e5cb83a3b183b2175f8b45fc Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes