Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F14EB200B8B for ; Tue, 20 Sep 2016 04:22:39 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EFFB6160ADC; Tue, 20 Sep 2016 02:22:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4178C160ACC for ; Tue, 20 Sep 2016 04:22:39 +0200 (CEST) Received: (qmail 20615 invoked by uid 500); 20 Sep 2016 02:22:35 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 20374 invoked by uid 99); 20 Sep 2016 02:22:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Sep 2016 02:22:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2152F1A0227 for ; Tue, 20 Sep 2016 02:22:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Qtwg-1bzT0ZQ for ; Tue, 20 Sep 2016 02:22:33 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D38545F3DC for ; Tue, 20 Sep 2016 02:22:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8K2MV9p013373; Tue, 20 Sep 2016 02:22:31 GMT Message-Id: <201609200222.u8K2MV9p013373@ip-10-146-233-104.ec2.internal> Date: Tue, 20 Sep 2016 02:22:31 +0000 From: "Anonymous Coward (Code Review)" To: Lars Volker , Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: davyxdh@163.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4028=3A_Improve_message_for_improper_Sentry_config_file_path_to__make_extra_spaces_visible=2E=0A?= X-Gerrit-Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634 X-Gerrit-ChangeURL: X-Gerrit-Commit: f948a588fcb453f33da8ce46b85c89fb65eaf288 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 20 Sep 2016 02:22:40 -0000 Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4309 to look at the new patch set (#5). Change subject: IMPALA-4028: Improve message for improper Sentry config file path to make extra spaces visible. ...................................................................... IMPALA-4028: Improve message for improper Sentry config file path to make extra spaces visible. When Sentry config file is incorrectly entered,the end contains spaces, impala starts up failed. Use quotes to embrace the file path in the error message that will help to identify the redundant spaces in the file path. Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634 --- M fe/src/main/java/com/cloudera/impala/authorization/SentryConfig.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/4309/5 -- To view, visit http://gerrit.cloudera.org:8080/4309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a76b9e4236caa3f2088fba8a9cf0236fced2634 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: davyxdh@163.com Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: davyxdh@163.com