Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201609192243.u8JMhkEI005831@ip-10-146-233-104.ec2.internal>
Date: Mon, 19 Sep 2016 22:43:46 +0000
From: "Michael Brown (Code Review)" <gerrit@cloudera.org>
To: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>
Reply-To: mikeb@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3739=3A_Enable_stress_tests_on_Kudu=0A?=
In-Reply-To: <gerrit.1473283375000.I3c9fc3dae24b761f031ee8e014bd611a49029d34@gerrit.cloudera.org>
References: <gerrit.1473283375000.I3c9fc3dae24b761f031ee8e014bd611a49029d34@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Mon, 19 Sep 2016 22:43:53 -0000

Michael Brown has posted comments on this change.

Change subject: IMPALA-3739: Enable stress tests on Kudu
......................................................................


Patch Set 5:

(2 comments)

It seems regardless of database, Kudu tables live in the same Kudu namespace. In order to have TPCH and TPCDS data both loaded, at least one of the customer tables must have a different name.

But also, it's often convenient to have the same data of varying scales loaded on a stress cluster for various experiments. Since we solve that problem by including the data scale in the database name, I think we could solve these problems in Kudu by including the Impala database as a prefix to each Kudu table.

Suggestion: prepend all the Kudu table names with the database name.

http://gerrit.cloudera.org:8080/#/c/4327/5/testdata/datasets/tpcds/tpcds_kudu_template.sql
File testdata/datasets/tpcds/tpcds_kudu_template.sql:

PS5, Line 469: 'kudu.table_name'='customer',
Here's one kudu table called 'customer'. Can this (and others) be expanded to "{target_db_name}_customer" ?


http://gerrit.cloudera.org:8080/#/c/4327/5/testdata/datasets/tpch/tpch_kudu_template.sql
File testdata/datasets/tpch/tpch_kudu_template.sql:

PS5, Line 185:   'kudu.table_name' = 'customer',
Here's another kudu table called "customer".


-- 
To view, visit http://gerrit.cloudera.org:8080/4327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c9fc3dae24b761f031ee8e014bd611a49029d34
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes