Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 29FBC200B86 for ; Sun, 18 Sep 2016 22:20:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 28612160AC3; Sun, 18 Sep 2016 20:20:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 65C4A160A8C for ; Sun, 18 Sep 2016 22:20:31 +0200 (CEST) Received: (qmail 87589 invoked by uid 500); 18 Sep 2016 20:20:30 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 87578 invoked by uid 99); 18 Sep 2016 20:20:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Sep 2016 20:20:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ED1B7C1CD8 for ; Sun, 18 Sep 2016 20:20:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AwYCM-rUMGEp for ; Sun, 18 Sep 2016 20:20:28 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id DCE505FAD2 for ; Sun, 18 Sep 2016 20:20:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8IKKL8o018507; Sun, 18 Sep 2016 20:20:21 GMT Message-Id: <201609182020.u8IKKL8o018507@ip-10-146-233-104.ec2.internal> Date: Sun, 18 Sep 2016 20:20:21 +0000 From: "Marcel Kornacker (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Remove_Llama_support=2E=0A?= X-Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef X-Gerrit-ChangeURL: X-Gerrit-Commit: e65cb0f90998cd0fc57d5a64c920bd62d76c66bd In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Sun, 18 Sep 2016 20:20:32 -0000 Marcel Kornacker has posted comments on this change. Change subject: Remove Llama support. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4445/1/be/src/scheduling/request-pool-service.cc File be/src/scheduling/request-pool-service.cc: Line 47: DEFINE_string(llama_site_path, "", "Path to the Llama configuration file " > This file is unfortunately still referenced by admission control even when good to know. please leave todo with explanatory comment. does this need to be a c6 cleanup item? -- To view, visit http://gerrit.cloudera.org:8080/4445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfb14209e31f6608bb7b8a33789e00411a6447ef Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes