Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2BEBA200B8F for ; Fri, 16 Sep 2016 00:22:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2AA25160AC6; Thu, 15 Sep 2016 22:22:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5DB38160ADC for ; Fri, 16 Sep 2016 00:22:24 +0200 (CEST) Received: (qmail 75042 invoked by uid 500); 15 Sep 2016 22:22:22 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 75031 invoked by uid 99); 15 Sep 2016 22:22:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Sep 2016 22:22:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E3EC3C0D74 for ; Thu, 15 Sep 2016 22:22:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ijcVOcJX6bXQ for ; Thu, 15 Sep 2016 22:22:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id B2DD95F1B3 for ; Thu, 15 Sep 2016 22:22:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8FMMJJC010343; Thu, 15 Sep 2016 22:22:19 GMT Message-Id: <201609152222.u8FMMJJC010343@ip-10-146-233-104.ec2.internal> Date: Thu, 15 Sep 2016 22:22:19 +0000 From: "Tim Armstrong (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4138=3A_Fix_AcquireState=28=29_for_batches_that_have_MarkCapacity=28=29_called=0A?= X-Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5 X-Gerrit-ChangeURL: X-Gerrit-Commit: e0b32405e0696cfef0a8cdf17a20ab973a4bcc12 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 15 Sep 2016 22:22:25 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that have MarkCapacity() called ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4428/1/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: Line 319: capacity_ = tuple_ptrs_size_ / (num_tuples_per_row_ * sizeof(Tuple*)); > What about just setting capacity_ = initial_capacity_ here? I don't feel strongly either way, but when this added I switched from the initial_capacity_ approach to the current approach to avoid redundant state: https://gerrit.cloudera.org/#/c/1399/8/be/src/runtime/row-batch.h@301 -- To view, visit http://gerrit.cloudera.org:8080/4428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ceca53c406b05cd04b7d95a4f9f2eec7bc127f5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes