Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201609151821.u8FILYxc005251@ip-10-146-233-104.ec2.internal>
Date: Thu, 15 Sep 2016 18:21:34 +0000
From: "Dimitris Tsirogiannis (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>, Michael Brown <mikeb@cloudera.com>
Reply-To: dtsirogiannis@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3739=3A_Enable_stress_tests_on_Kudu=0A?=
In-Reply-To: <gerrit.1473283375000.I3c9fc3dae24b761f031ee8e014bd611a49029d34@gerrit.cloudera.org>
References: <gerrit.1473283375000.I3c9fc3dae24b761f031ee8e014bd611a49029d34@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Thu, 15 Sep 2016 18:21:40 -0000

Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-3739: Enable stress tests on Kudu
......................................................................


Patch Set 4:

(3 comments)

Thanks for calling these out mikeb.

http://gerrit.cloudera.org:8080/#/c/4327/4/testdata/datasets/tpcds/tpcds_kudu_template.sql
File testdata/datasets/tpcds/tpcds_kudu_template.sql:

PS4, Line 263: 'kudu.key_columns'='sr_returned_date_sk,sr_ticket_number, sr_item_sk',
> In TPC-DS, the primary keys are sr_item_sk, sr_ticket_number . Is this diff
Done


PS4, Line 575: 'kudu.key_columns'='hd_demo_sk,hd_income_band_sk',
> In TPC-DS only hd_demo_sk is a primary key.
Done


PS4, Line 643: 'kudu.key_columns'='p_promo_sk, p_item_sk',
> In TPC-DS, only p_promo_sk is a primary key.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c9fc3dae24b761f031ee8e014bd611a49029d34
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes