Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EDE0A200B91 for ; Thu, 15 Sep 2016 03:52:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EC840160AD4; Thu, 15 Sep 2016 01:52:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4070D160AB4 for ; Thu, 15 Sep 2016 03:52:40 +0200 (CEST) Received: (qmail 69577 invoked by uid 500); 15 Sep 2016 01:52:39 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 69566 invoked by uid 99); 15 Sep 2016 01:52:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Sep 2016 01:52:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C3D79C06E9 for ; Thu, 15 Sep 2016 01:52:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id JS8GHov-0aqw for ; Thu, 15 Sep 2016 01:52:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B8ED35FC89 for ; Thu, 15 Sep 2016 01:52:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8F1qaU5023977; Thu, 15 Sep 2016 01:52:36 GMT Message-Id: <201609150152.u8F1qaU5023977@ip-10-146-233-104.ec2.internal> Date: Thu, 15 Sep 2016 01:52:36 +0000 From: "Lars Volker (Code Review)" To: Sailesh Mukil , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Make_gen_build_version=2Epy_resilient_to_a_failing_git_rev-parse=0A?= X-Gerrit-Change-Id: Id7af33502bbb70185dc15ffca6219436a616f25b X-Gerrit-ChangeURL: X-Gerrit-Commit: 6cc6e1d8017232341c26e47e295a6197d2354c1c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 15 Sep 2016 01:52:41 -0000 Lars Volker has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4411/3/bin/gen_build_version.py File bin/gen_build_version.py: Line 35: # Redirecting stdout and stderr to os.devnull > Didn't realize this earlier, but None actually doesn't redirect stdout or s Uh, I didn't know either. Nice way to redirect the output. -- To view, visit http://gerrit.cloudera.org:8080/4411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7af33502bbb70185dc15ffca6219436a616f25b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes