Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201609140411.u8E4B6YL004900@ip-10-146-233-104.ec2.internal>
Date: Wed, 14 Sep 2016 04:11:06 +0000
From: "Alex Behm (Code Review)" <gerrit@cloudera.org>
To: Huaisi Xu <hxu@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>,
        Bharath Vissapragada <bharathv@cloudera.com>
Reply-To: alex.behm@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1702=3A_Enforce_unique_table_ID=0A?=
In-Reply-To: <gerrit.1473443647000.Ifad648b72684ae495ec387590ab1bc58ce5b39e2@gerrit.cloudera.org>
References: <gerrit.1473443647000.Ifad648b72684ae495ec387590ab1bc58ce5b39e2@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 14 Sep 2016 04:11:12 -0000

Alex Behm has posted comments on this change.

Change subject: IMPALA-1702: Enforce unique table ID
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/com/cloudera/impala/catalog/CatalogServiceCatalog.java:

Line 188:     private final HashMap<TTableName, TableId> tblIdMap_ =
> yeah, but ideally any table change should trigger a new analyzing just like
You raise a good point. Maybe we should consider how to ensure at least table-level consistency during analysis. For example, one way could be to add referenced Tables into the Analyzer such that subsequent references will see the same Table object (instead of going to the Catalog every time).

Seems relatively easy to do.

Dimitris also has a good point that distinguishing the drop+add case from the invalidate case may be hard, but I think the proposed Analyzer change above should handle that, right?


-- 
To view, visit http://gerrit.cloudera.org:8080/4349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <hxu@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes