Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CE3F7200B8C for ; Mon, 12 Sep 2016 20:15:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CD32A160AB8; Mon, 12 Sep 2016 18:15:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 20B93160AB2 for ; Mon, 12 Sep 2016 20:15:34 +0200 (CEST) Received: (qmail 39171 invoked by uid 500); 12 Sep 2016 18:15:34 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 39153 invoked by uid 99); 12 Sep 2016 18:15:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2016 18:15:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 01DD5C1810 for ; Mon, 12 Sep 2016 18:15:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id INjvX1-j-itk for ; Mon, 12 Sep 2016 18:15:30 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id E6CB15FBB8 for ; Mon, 12 Sep 2016 18:15:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u8CIFSX9013896; Mon, 12 Sep 2016 18:15:28 GMT Message-Id: <201609121815.u8CIFSX9013896@ip-10-146-233-104.ec2.internal> Date: Mon, 12 Sep 2016 18:15:28 +0000 From: "Matthew Jacobs (Code Review)" To: Sailesh Mukil , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3823=3A_Add_timer_to_measure_Parquet_footer_reads=0A?= X-Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf X-Gerrit-ChangeURL: X-Gerrit-Commit: 2e7b475d4dd31dae3f17dee4493fd0e5592f8532 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 12 Sep 2016 18:15:36 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4371/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: PS2, Line 343: # The chance that the times taken by different scan ranges to process the footer, : # are equal, is very unlikely. However, it could happen which could make the min and : # max time to process a footer equal. Assert that at a time, no more than 1 node has : # equal min and max time. : assert num_equal < 2 this seems brittle... how about checking that: 0 <= min <= avg <= max < total time (e.g. scanner thread wall clock time?) -- To view, visit http://gerrit.cloudera.org:8080/4371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes